roucherj <roucherj@xxxxxxxxxxxxxxx> writes:
> On Sat, 09 Jun 2012 21:52:36 +0200, konglu@xxxxxxxxxxxxxxx wrote:
>>> +void cmd_credential (int argc, char **argv, const char *prefix){
>>> + const char *op;
>>> + struct credential c = CREDENTIAL_INIT;
>>> + int i;
>>> +
>>> + op = argv[1];
>>> + if (!op)
>>> + usage(usage_msg);
>>> +
>>> + for (i = 2; i < argc; i++)
>>> + string_list_append(&c.helpers, argv[i]);
>>> +
>>> + if (credential_read(&c, stdin) < 0)
>>> + die("unable to read credential from stdin");
>>> +
>>> + if (!strcmp(op, "fill")) {
>>> + credential_fill(&c);
>>> + if (c.username)
>>> + printf("username=%s\n", c.username);
>>> + if (c.password)
>>> + printf("password=%s\n", c.password);
>>> + }
>>> + else if (!strcmp(op, "approve")) {
>>> + credential_approve(&c);
>>> + }
>>> + else if (!strcmp(op, "reject")) {
>>> + credential_reject(&c);
>>> + }
>>> + else
>>> + usage(usage_msg);
>>
>> Braces for the last "else" part. In general, the structure should be
>>
>> if (...) {
>> /*code*/
>> } else if (...) {
>> /*code*/
>> } else {
>> /*code*/
>> }
>>
>> If juste one block needs brances, all the other "else if"/"else" part
>> need it too.
>>
>> BTW, please be aware of the white spaces (here mostly in the doc) :).
>>
>> Lucien Kong.
>
> I will remove brances.
The remark was about adding them, not removing them. There's one branch
of the if/else if/ with several instructions, so we usually put braces
everywhere.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html