Re: [PATCH 1/3] Script to install, delete and clear a MediaWiki

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Simon Cathebras <simon.cathebras@xxxxxxxxxxxxxxx> writes:

> From: Guillaume Sasdy <guillaume.sasdy@xxxxxxxxxxxxxxx>
>
> install_wiki.sh expects the first argument to be 'install' or 'delete'
> 'install' installs a MediaWiki on the web's server with SQLite3
> 'delete' deletes the previously created wiki.
> Note those functionnalities are made to be used from the user command line in
> the directory t/
>
> install_wiki also defines a function wiki_reset which clear all content
> of the previously created wiki. Note this functionnality is made to be
> used only by our test function in a subdirectory of t/
>
> Signed-off-by: Simon Cathebras <simon.cathebras@xxxxxxxxxxxxxxx>
> Signed-off-by: Guillaume Sasdy <guillaume.sasdy@xxxxxxxxxxxxxxx>
> Signed-off-by: Julien Khayat <julien.khayat@xxxxxxxxxxxxxxx>
> Signed-off-by: Simon Perrat <simon.perrat@xxxxxxxxxxxxxxx>
> Signed-off-by: Charles Roussel <charles.roussel@xxxxxxxxxxxxxxx>
> Signed-off-by: Matthieu Moy <matthieu.moy@xxxxxxx>
> ---
>  t/install-wiki.sh                |  38 ++++++++++
>  t/install-wiki/LocalSettings.php | 129 ++++++++++++++++++++++++++++++++
>  t/install-wiki/db_install.php    | 110 ++++++++++++++++++++++++++++
>  t/test-gitmw-lib.sh              | 154 +++++++++++++++++++++++++++++++++++++++

Hrm, I see my name on the Cc: list, but is this meant to go into my tree?

The t/ directory is a very strange place to put an installation
procedure for anything.  Is this because later test scripts that
test mw-to-git gateway need to have a mediawiki instance that runs
locally?

I am wondering why it is not sufficient to structure the MediaWiki
related tests more like existing tests that require a running HTTP
server, namely, t/lib-httpd.sh that allows such tests to proceed
only if a suitable server is available, but we do not ship a script
to install Apache for that.

>  mode change 100644 => 100755 t/test-lib-functions.sh
>  mode change 100644 => 100755 t/test-lib.sh

Why?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]