On Fri, Jun 01, 2012 at 12:02:08PM -0500, Kevin Stange wrote: > > The dumb-http push code is the only thing that does not go through > > http_request these days. So another option would be to refactor it to go > > through that central point. I took a brief look at this when I was > > updating the credential code a few months ago, but didn't consider it a > > priority, as most people should be using smart http these days. Is there > > a reason you can't use smart-http? It's significantly more efficient. > > Smart HTTP didn't come up in any of my Google searches. With that as an > option, I might just drop this work now. I'd rather see incomplete methods > that aren't recommended go away than further facilitate their use, personally. Me too. I would love it if dumb http push just went away. It's extremely neglected, and has very few advantages over smart http (really, the only advantage is that the server does not need to run git). However, we do get bug reports on it occasionally, so I think people are still using it. So far our approach has mostly been to prevent any serious regressions, and otherwise not worry too much about dragging it along with new features. > I made the change where I did because I wasn't sure if the push code was > avoiding using http_request intentionally, and wasn't sure whether new code > would be written that avoid it as well. > > If that's not the case, then I gather http-push would be better rewritten to > just use http_request, if anything. Yes, I think so. It's purely historical and accidental that the http-push code does not use it (and that the 401-handling happened to be put at that layer). The push and fetch sides grew up independently and organically; I think if somebody were writing it now, they would organize http.c quite differently. > If I decide to continue working on this, I will keep these in mind. I'm > pretty sure that if I can get smart HTTP working, there's no reason to even > bother with this from my perspective, unless you think there's substantial > value in it. No, I don't think there's substantial value. If you can move to smart http, you are much better off. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html