Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@xxxxxxxxxxxxxxx> writes: > +test_expect_success 'write: xdg file exists and ~/.gitconfig doesn'\''t' ' > + mkdir -p .config/git && > + >.config/git/config && > + rm .gitconfig && > + git config --global user.name "write_config" && > + echo "[user]" >expected && > + echo " name = write_config" >>expected && > + test_cmp expected .config/git/config > +' It was suggested that you also write to the XDG file if the XDG _directory_ exists. After thinking about it, I tend to disagree with this, because creating ~/.config/git/ignore would let Git write to the XDG configuration file as a side effect, which I find strange. Anyway, you may add the case where ~/.config/git/ exists but not the config file in it to your tests, to materialize the decision you have taken on that point. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html