On Mon, Jun 4, 2012 at 8:10 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jon Seymour <jon.seymour@xxxxxxxxx> writes: > > Style: please align case/esac and the labels on case arms (see how > two existing nested case statements in this function are written). Thanks. > Didn't we add some workaround for implementations of sed that do not > match and replace a possibly empty pattern? Am I seeing the same > breakage as c5bc42b (Avoid bug in Solaris xpg4/sed as used in > submodule, 2012-04-09) addressed with this patch? Have modified accordingly. It may not have mattered *much* in this case since I think normalisation during git submodule add would have ensured at least one matching character, but then I don't pretend to understand the nature of the Solaris issue and that would in any case, not protect against a manual .gitmodules edit. I'll re-roll in a day or so after Jens (and/or others) have had a chance to comment. jon. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html