Re: Bug: git ls-files and ignored directories

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christoph Buchner <bilderbuchi@xxxxxxxxxxxx> writes:

[please do not top-post]

> On 06/03/2012 12:56 AM, Junio C Hamano wrote:
>
>> The patches are queued to 'pu'.  Do they fix your issue?
> 
> Yes they do.
> In my test repo, git compiled from current pu branch shows
> git ls-files --exclude-standard -i
> apps/devApps/projectGenerator/.svn/wrongly-committed-svn.txt
> apps/devApps/projectGenerator/some-wrong-file.txt
> while git 1.7.9.5 shows
> apps/devApps/projectGenerator/some-wrong-file.txt
>
> Thank you for fixing this! Which git release is planned to contain the
> fix (if that can be said yet)? I'm not familiar with your workflow..

As we are already in "regression fix only" phase, it won't be in the
upcoming 1.7.11 series, even though it may deserve to be in 1.7.11.2
maintenance release.

I see other uses of excluded() in builtin/add.c and unpack-trees.c;
these call sites need to be audited.

If they have the same problem, it probably is a good idea to convert
them to use path_excluded(), move the path_excluded() function and
its supporting infrastructure from builtin/ls-files.c to dir.c, and
make excluded() a file-static function to dir.c in order to avoid
similar problems in the future.  Or their use may be alright.

The work described in the previous paragraph preferrably should
happen before the change is shipped as part of any release.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]