Re: [PATCH v7 6/9] submodule: fix detection of invalid submodule URL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 29, 2012 at 7:39 AM, Jon Seymour <jon.seymour@xxxxxxxxx> wrote:
> On Tue, May 29, 2012 at 5:01 AM, Johannes Sixt <j6t@xxxxxxxx> wrote:
>> Am 27.05.2012 17:34, schrieb Jon Seymour:
>>
>> Without understanding in detail what this series is about, I would guess
>> that the previous two case arms are not very Windows friendly. Does the
>> right thing happen when $remoteurl is "c:/path/to/remote"? Would it help
>> to use is_absolute_path?
>>
>>        if is_absolute_path "$remoteurl"
>>        then
>>                variant="${remoteurl#*/}"
>>        else
>>                case "$remoteurl" in
>>                ...other cases go here...
>>                esac
>>        fi
>>
>> -- Hannes
>
> Thanks, I will investigate this as an alternative.
>

I did investigate is_absolute_path for the v8 roll of this series, but
I found it wasn't suitable because it doesn't classify URLs of the
form user@host:repo as absolute. You can find the alternative I did
use in v8 3/4.

Regards,

jon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]