Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> writes:
I have not tried this patch (or the v3 version, which I haven't read
yet), but
is it likely that this has re-introduced the bug addressed by commit 05bab3ea
("config.c: Fix a static buffer overwrite bug by avoiding mkpath()",
>19-11-2011)?.
I don't know the answer, but I suspect that it may have done just
that. >(indeed, it
may well have made the bug more likely to appear).
The original that read from $HOME/.gitconfig was simple enough so
having three copies of getenv("HOME") was perfectly fine, but as you
are introduce this much complexity to to decide which two files to
read from, the code added this patch needs to be refactored and
three copies of the same logic need to be consolidated, I would have
to say.
I agree. Also, using mksnpath() in the refactored code (rather than
mkpath()) would be a good idea. :-P
ATB,
Ramsay Jones
Is not mkpath() the same function as mksnpath with char *buff =
buf[PATH_MAX] and size_t n = sizeof(buf) ?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html