On 31/05/2012 09:17, Matthieu Moy wrote:
+ result=$(diff -r -B -w --exclude=".git" "$1" "$2")
Doesn't seem to be in POSIX:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/diff.html
Will this run on all platforms?
Indeed. According to the POSIX manual, the option -B and -w are merged
in the single option -b.
In addition, -r option still exists (to compare recursively two
directories).
The previous instruction will be write as follow :
diff -r -b "$first_folder" "$second_folder"
With this fix, it will works on all platforms. ;)
+my $wiki_url="http://localhost/wiki/api.php";;
+my $wiki_admin='WikiAdmin';
+my $wiki_admin_pass='AdminPass';
It would be nice to allow overriding these from the command-line. But as
you are now writting tests, you may as well apply the YAGNI
principle ;-).
Does it seems important for you to overriding these from CL ?
By default, those settings work fine. You have to edit this only if you
need a special configuration. But it is purely optionnal.
Included in v2 patches:
* Fixing errors pointed above.
* Sqlite file excluded from the patches. Mainly with reviewing the
wiki_install script.
On the other hand, considering the git-mediawiki is curently on contrib
branch, shall we move our test environement from git/t to git/contrib/t ?
SimonC
--
CATHEBRAS Simon
2A-ENSIMAG
Filière Ingéniérie des Systèmes d'Information
Membre Bug-Buster
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html