Re: [PATCH 2/6] reflog: remove i18n legos in pruning message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder <jrnieder@xxxxxxxxx> writes:

> Thanks.  Style: how about
>
> 	if (!cb->newlog)
> 		printf("would prune %s", message);
> 	else if (cb->cmd->verbose)
> 		printf("prune %s", message);
>
> ?  I think that would be more readable than the lego original.

That is very much more preferred.

> BTW I'm not sure if this message would be a good candidate for
> translation.

These are for human consumption; they used to go to standard error
stream back when it was written at 4264dc1 (git reflog expire,
2006-12-19).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]