On Thu, May 31, 2012 at 8:45 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Thanks. Style: how about > > if (!cb->newlog) > printf("would prune %s", message); > else if (cb->cmd->verbose) > printf("prune %s", message); > > ? I think that would be more readable than the lego original. thanks > BTW I'm not sure if this message would be a good candidate for > translation. Especially in the --dry-run case, it feels like output > that is intended to be simple enough for scripts to parse. (Though on > the other hand, I don't know of any scripts or use cases that actually > parse it, so maybe nobody would mind.) it's gray area. reflog is not categorized as plumbing. Maybe adding --plumbing for scripts? -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html