Jakub Narebski <jnareb@xxxxxxxxx> writes: > Junio C Hamano wrote: >> ... >> The counting code in git_*_body is seriously unusual to tempt >> anybody who reviews the code to reduce that 17 to 16. > > Well, this should be then corrected perhaps to Well, I did not say it was _wrong_, just unusual, so there is nothing to fix. >> By the way, I wonder how that $extra is omitted when $revlist is >> longer than $to; it should be a trivial fix but it seems to me >> that it is always spitted out with the current code. > > We should check if we want to omit $extra, either in caller or > in callee, the *_body subroutine itself. Check? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html