Re: [PATCH v6 8/9] submodule: fix handling of denormalized superproject origin URLs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 27, 2012 at 11:43 PM, Jon Seymour <jon.seymour@xxxxxxxxx> wrote:
> This change also fixes a subtle error in the setup of t7403 which was
> masked by the denormalization issue. Previous behaviour was
> relying on submodule add to clone trash/submodule into super/submodule,
> however from the perspective of super's origin (i.e. trash), the origin
> submodule is actually located at ./submodule not ../submodule. However,
> because the origin URL of super was denormalized (it had a trailing /.)
> the incorrect handling of denormalized super URLs actually produced
> the correct result - a case of two errors cancelling out each other's
> effects.
>

Forgot to check the other test scripts for a similar issue. This
change breaks the following tests:

   t7406-submodule-update.sh
   t7407-submodule-foreach.sh
   t7506-status-submodule.sh

possibly because of the same issue mentioned in regard to t7403.

In any case, better not to apply this to pu until I have had a chance
to re-roll a v7

jon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]