Re: [PATCH] fetch-pack: avoid fixing thin packs when unnecessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Dec 2006, Johannes Schindelin wrote:

> 
> When we know that there are no common commits, the pack must be
> closed (i.e. non-thin) already. Avoid "fixing" it in that case.
> 
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
> 
> ---
> 
> 	On Mon, 18 Dec 2006, Johannes Schindelin wrote:
> 
> 	> On Mon, 18 Dec 2006, Randal L. Schwartz wrote:
> 	> 
> 	> > But then it took nearly an *hour* at the next phase:
> 	> > 
> 	> >   Resolving 313037 deltas.
> 	> >    100% (313037/313037) done
> 	> 
> 	> Ouch.
> 	> 
> 	> We try to avoid unpacking the thin packs received by git-fetch.
> 	> This means completing that pack (since it can contain deltas 
> 	> against objects which are part of another pack).
> 	> 
> 	> However, for the clone this is utter overkill. We really should 
> 	> try to avoid resolving unnecessarily. This is really for the 
> 	> clone case, since we do not have _any_ objects in the local 
> 	> repository.
> 	> 
> 	> It happens that the other case -- fetching an independent branch 
> 	> -- is easy enough: we already have the check for it in 
> 	> fetch-pack.c:586.
> 
> 	... and here is a lightly tested fix.

NAK.

This fixes nothing.  See previous message.


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]