On Thu, May 24, 2012 at 05:08:15PM -0700, Junio C Hamano wrote: > > [5/7]: ident: rename IDENT_ERROR_ON_NO_NAME to IDENT_STRICT > > [6/7]: ident: reject bogus email addresses with IDENT_STRICT > > [7/7]: format-patch: do not use bogus email addresses in message ids > > > > These ones prevent bogus message ids from being generated at all > > (which is an improvement over the previous state). > > All looked pretty straightforward and cleanly done. > > We might want to further tighten 6/7 to verify user-supplied (i.e. non > default) e-mail for sanity, as I agree with the comment below --- lines of > that patch. Yeah. I'd be fine with more tightening, but I wanted to just catch the most common uncontroversial problem in the initial round. We can build on top later if we want. > Also the check might want to be further tightened in the RFC 822/2822/5322 > sense, but getting it correct will open a huge can of worms; I think the > check in 6/7 is a good place to stop, at least for now. Yeah, I considered that, but got nervous thinking about the same can of worms. It is not like people are complaining now, so I'd rather leave it. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html