Re: [PATCH] git-parse-remote: fix ambiguous shell bug in expand_refs_wildcard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> Bash and dash parse "${name%'^{}'}" differently, with bash quoting the
> ^{}, and dash assuming the first } is the end of the variable (and thus
> tacking '} to the end). Instead, use backslash to quote the closing
> brace.

Sounds like a dash bug, if my reading of 2.6.2 Parameter
Expansion is correct:

    http://www.opengroup.org/onlinepubs/000095399/utilities/xcu_chap02.html

We should work it around nevertheless; thanks for the patch,
Jeff.

This would be another way to work it around.  Both dash and bash
say 'foo':

        $ suf='^{}'
        $ name='foo^{}'
        $ echo "${name%$suf}"
        foo

I think this might be easier to read than using "^{\}".


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]