From: Jonathan Nieder <jrnieder@xxxxxxxxx> > Christian Couder wrote: > >> "struct unpack_trees_options" has a "const char *msgs[]" field >> that is setup with string values in setup_unpack_trees_porcelain(). > > Hmm. Incidentally, should callers (e.g., the 100 single-picks > involved in a large multi-pick) be reusing these strings instead of > allocating them again and again? Some strings filling the msgs field are created with sprintf() using the cmd argument passed to setup_unpack_trees_porcelain(). So they could be different if different cmd arguments are used. In practice now cmd is either "checkout" or "merge", so we could probably reuse the same strings. But if we ever add a checkout command to the sequencer for example, we might want to use different error messages. Another possibility is to xmalloc all the strings and then free them all. Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html