Re: git rev-list %an, %ae, %at bug in v1.7.10.1 and beyond

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 22, 2012 at 01:58:11AM -0400, Jeff King wrote:

>   $ git init
>   $ echo content >foo && git add foo
>   $ GIT_AUTHOR_NAME=a git commit -m msg
>    Author:  <>
>    1 file changed, 1 insertion(+)
>    create mode 100644 foo
> 
> Uh oh, that's odd. And worse:
> 
>   $ git log -1 --format='|%an <%ae>|'
>   | <>|
> 
> So there is definitely a bug. The unicode thing is a red herring, and if
> there was any unicode at some point, git stripped it out when making the
> commit. The real regression seems to be in single-character names.
> 
> I'll see if I can find the bug.

Both are caused by an off-by-one error in split_ident_line. I just
posted a patch.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]