Re: [PATCH v2 1/5] Add convenient function to do automatic garbage collection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 19, 2012 at 5:37 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:
>
>> This function also avoids forking most of the time by performing some
>> check in process.
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
>> ...
>> @@ -64,6 +66,10 @@ static int gc_config(const char *var, const char *value, void *cb)
>>               }
>>               return git_config_string(&prune_expire, var, value);
>>       }
>> +     if (cb && !strcmp(var, cb)) {
>> +             auto_gc = git_config_bool(var, value);
>> +             return 0;
>> +     }
>
> This does not look like "add convenient function for auto-gc" nor "avoid
> forking"; it is something else that is not explained.

It takes care of "foo.autogc" config key in commands that allows to
suppress auto gc. But yes, commit message can use some improvement.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]