Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:
> This makes it more convenient in cleanup code, like free(NULL).
If the justification were "like fclose(NULL)", it have made more sense,
but fclose(NULL) does not silently turn itself into a successful no-op.
You are expected to check the returned value from the matching function
(i.e. fopen()) and do not call it. So taking this patch alone, I smell
a bad design taste.
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
> ---
> streaming.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/streaming.c b/streaming.c
> index 3a3cd12..38b39cd 100644
> --- a/streaming.c
> +++ b/streaming.c
> @@ -94,7 +94,7 @@ struct git_istream {
>
> int close_istream(struct git_istream *st)
> {
> - int r = st->vtbl->close(st);
> + int r = st ? st->vtbl->close(st) : 0;
> free(st);
> return r;
> }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html