> I suggest that you apply the same kinds of cleanups to > git-convert-index.py (which I personally haven't looked at yet at > all). If you want my feedback on that script, please let me know > when you think it is ready. That would be great, if you have the time to do it. I'm not completely finished with it (docstrings and conflicted data writing are still missing). I'm not sure about the read_tree_extensiondata method, if I should extract a method, which only reads one entry, but I'm not sure that would make any sense, since there would be a lot of parameters and return values to the function. The same thing is in the main method, where I'm not sure if it's better to extract the read_index and write_index functions, or just leave the code in the main method. My guess is that it makes sense in the main method, since there are less calls, but it doesn't make sense in the read_tree_extensiondata method? Another thing I'm unsure about is the write_directory_data method, if there is any way to replace the try/except with something simpler? -- Thomas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html