Re: [PATCH v2] git-svn: clarify the referent of dcommit's optional argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Jon Seymour <jon.seymour@xxxxxxxxx> writes:
>
>> On Tue, May 15, 2012 at 2:16 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>>
>>> The only reason why the original is not ordered that way, as far as I can
>>> tell, is because "It is recommended that" was part of an existing paragraph
>>> when dd31da2 (git-svn: allow dcommit to take an alternate head, 2006-12-12)
>>> added "An optional ...", so it was tucked after existing paragraph without
>>> reading the resulting whole to see if "at the very end" was the best place.
>>
>> Re-reading this, I don't think the advice:
>>
>>     "It is recommended that you run 'git svn' fetch and rebase (not
>>     pull or merge) your commits against the latest changes in the =C2=A0SVN
>>     repository."
>>
>> really belongs in the description of dcommit at all.
>
> I tend to agree.  Opinions from git-svn experts?

I agree that this is not dcommit-specific advice.  Perhaps there should
be a longer section that explains in detail what is rebased how and thus
what the limitations of dcommit are.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]