Jeff King <peff@xxxxxxxx> writes: > So it seems to me like a much simpler set of rules would be: > > 1. When reading gecos, always fall back to the username if the gecos > field is unavailable or blank. > > 2. Always die when the name field is blank. That means we will die > when you pass in a bogus empty GIT_COMMITTER_NAME (or an empty > config name), which makes a lot more sense to me than falling back; > those are bogus requests, not system config problems. And we won't > ever have a blank gecos name, because we'll always fall back on the > username. That certainly sounds very simple to explain and understand, and I do not offhand think of anything *sane* that would break ;-) Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html