On Mon, May 14, 2012 at 9:09 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >>> Here is my attempt to explain why none of them needs to be quoted: >>> ... >> I don't understand that. > > That was my attempt to give the readers some context to understand what > comes after that. If the original patch author does not understand it, > perhaps it is an indication that the function is somewhat underdocumented. I mean I don't understand this "Note that none of the variable reference in the implementation of this function needs dq around it." I suppose you meant 'references' (as that would make it grammatically correct AFAICS), but I still don't understand what you are trying so say. That the way the arguments are used in the __git_complete function makes it so double quotes are irrelevant? If so, then yeah, I agree. Is there something actionable? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html