Jeff King <peff@xxxxxxxx> writes: > I think the behavior is correct, but the message confused me. If I see > "cannot append a foo to a bar", it implies to me that it is the > combination of the elements that is the limiting factor. But it is not. > It is that one (or more) of the elements is not a blob, regardless of > what the other element is. So I think this would be more accurate: > > if (type != OBJ_BLOB) > die(_("cannot append to a non-blob note")); > if (msg->type != OBJ_BLOB) > die(_("cannot append a non-blob object to a note")); It certainly looks easier to grok. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html