René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > The functions xdl_cha_first(), xdl_cha_next() and xdl_atol() are not used > by us. While removing them increases the difference to the upstream > version of libxdiff, it only adds a bit to the more than 600 differing > lines in xutils.c (mmfile_t management was simplified significantly when > the library was imported initially). Besides, if upstream modifies these > functions in the future, we won't need to think about importing those > changes, so in that sense it makes tracking modifications easier. I was of two minds wondering the exact pros-and-cons you described above, but OK, let's shrink it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html