SZEDER Gábor <szeder@xxxxxxxxxx> writes: > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index ab26bdc8..cd6a5f12 100755 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -258,7 +258,7 @@ __git_ps1 () > esac 2>/dev/null)" || > > b="$(cut -c1-7 "$g/HEAD" 2>/dev/null)..." || > - b="unknown" > + return While you are touching the vicinity of the code, could we lose that "cut" and replace it with "rev-parse --short HEAD", without the hardcoded 1-7? I wondered if we can use a single "git describe" output for all the describe/default and failure cases but didn't come up with a good way to do so only by using bash built-ins. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html