On Mon, May 7, 2012 at 8:59 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> On Mon, May 7, 2012 at 3:23 AM, Felipe Contreras >> <felipe.contreras@xxxxxxxxx> wrote: >> >>> @@ -2642,6 +2642,8 @@ _git () >>> return >>> fi >>> >>> + (( cmd_pos = c + 1 )) >> >> Actually, I would prefer cmd_pos=$((c + 1)). > > Yeah, that would feel more natural. > > Together with 4/6, I am guessing that you are using $cmd and $cmd_pos as a > global variable to pass state to/from helper functions. Are they properly > documented in code (if not, please do so)? Like cur, prev, words, and cwords? Wait a second... they are not documented anywhere. I'm also not going to work on this... not my itch. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html