On Sun, 06 May 2012 12:03:49 +0200 Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> writes: > > > Maybe this -x option should conflict with -i to simplify its "execute > > the command after each commit" semantics (what if it is combined with -i > > and 'x/exec' lines?). > > Actually, implementation-wise, it's simpler to have '-x' imply '-i', and > suggest a todo-list containing 'x' lines. Then, the code would simply > have to add these "x whatever" lines, and let the > "git-rebase--interactive.sh" mechanics do the job. That would show the > "x whatever" lines to the user, but that can be seen as added value, > since it gives an opportunity to the user to remove or edit some of them > if needed. > Thanks Matthieu, this sounds like a reasonable default behavior for the case of '-x' and '-i' _combined_, but I still think '-x' with no invocation of $EDITOR can have its use case (e.g. a "make validate-commits" calling 'git rebase -x "make test" master'). But I'd like to hear other opinions about that. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpilfAQhGOZR.pgp
Description: PGP signature