Re: [PATCH] Avoid accessing a slow working copy during diffcore operations.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> On Fri, 15 Dec 2006, Junio C Hamano wrote:
>
>> Also I'd prefer doing this without #ifdef;
>> 
>>         if (defined(NO_FAST_WORKING_DIRECTORY) &&
>>         	!want_file && has_sha1_pack(sha1, NULL))
>> 		return 0;
>
> Are you sure? AFAIU it is an OS dependent problem, so it should not be 
> configurable at runtime anyway.

Well, defined(SYMBOL) does not seem to be a valid C X-<, and I
rewrote it in what I committed.  But the point was that the
whole thing:

	if (!FAST_WORKING_DIRECTORY && whatever)
		statement;

when FAST_WORKING_DIRECTORY is a compilation time constant,
would be optimized out for sane platforms with a reasonable
compiler.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]