On Tue, 1 May 2012, Jeff King wrote: > On Tue, May 01, 2012 at 01:59:08PM -0400, Nicolas Pitre wrote: > > > One final quick test if you feel like it: I've never been sure that > > the last comparison in type_size_sort() is correct. Maybe it should be > > the other way around. Currently it reads: > > > > return a < b ? -1 : (a > b); > > I think it is right. At least it should put recent things near the > front of the array, just as we are putting bigger things there. Right. In fact, it seems that _I_ did think about it *five* years ago (man... time flies by) given commit adcc70950e, and then I reversed the whole order in commit b904166ccb to get what we have today. > > replace this line with: > > > > return b < a ? -1 : (b > a); > > No, it's not better. A few of the pack sizes are better, but some of > them are worse. And the CPU times are still quite bad. OK. We can scratch that. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html