On Tue, 1 May 2012, Junio C Hamano wrote: > Nicolas Pitre <nico@xxxxxxxxxxx> writes: > > > One final quick test if you feel like it: I've never been sure that > > the last comparison in type_size_sort() is correct. Maybe it should be > > the other way around. Currently it reads: > > > > return a < b ? -1 : (a > b); > > > > While keeping the size comparison commented out, you could try to > > replace this line with: > > > > return b < a ? -1 : (b > a); > > > > If this doesn't improve things then it would be clear that this avenue > > should be abandoned. > > Very interesting. The difference between the two should only matter if > there are many blobs with exactly the same size, and most of them delta > horribly with each other. Does the problematic repository exhibit such > a characteristic? Not precisely. This is just to verify some hypothesis that could explain the difference in behavior with the phpmyadmin repo. My hypothesis was that recency order could be skewed by the object size when many small changes are made to the same files without varying their size much. So I suggested that a repack run be performed with the object size removed from the sort criteria. However it is important that the last comparison be done in the right direction. Hence my suggestion above. > The original tie-breaks based on the address (the earlier object we read > in the original input comes earlier in the output) and yours make the > objects later we read (which in turn are from older parts of the history) > come early, but adjacency between two objects of the same type and the > same size would not change (if A and B were next to each other in this > order, your updated sorter will give B and then A still next to each > other), so I suspect not much would change in the candidate selection. Note that the size comparison is commented out in those tests. The idea was to get pure recency order. Even for objects of the same size, the delta orientation would change which might or might not provide a clue. But this is really just a wild guess without much thinking at this point, before giving up on this approach. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html