Hi Eric,
> > This does textual comparison, so 1.6.6 > 1.6.12. To do proper version
> > comparison, I think the version numbers should be split into
> > major/minor/revision and each be compared numerically.
>
> Ah, thanks for the analysis, we were lucky in the past that all version
> components only had a single character.
Indeed. Note that this includes the released subversion versions. For
example, the code contains this check:
$SVN::Core::VERSION le '1.5.4'
and 1.5.10 < 1.5.4. Fortunately, 1.5.9 was the last release in the 1.5
series, and no other checks compare against 1.6.x.
If subversion would ever reach the 1.10.x version number, things would
also start breaking.
> I think the former is preferable for git. Sort::Versions isn't used
> anywhere else in git and I don't think it's widely installed.
I guessed as much. I'll have a look at providing a patch.
Gr.
Matthijs
Attachment:
signature.asc
Description: Digital signature