Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > Before this patch write_tar_entry() can: > > - write global header > by write_global_extended_header() calling write_tar_entry with > with both sha1 and path == NULL > > - write extended header for symlinks, by write_tar_entry() calling > itself with sha1 != NULL and path == NULL > > - write a normal blob. In this case both sha1 and path are valid. > > After this patch, the first two call sites are modified to write the > header without calling write_tar_entry(). The function is now for > writing blobs only. Nice. I am kind of surprised how hacky the original code that switched on !sha1 and !path was, especially given that it came from René at ae64bbc (tar-tree: Introduce write_entry(), 2006-03-25) --- it even claims that these are "reasonable" magic values ;-). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html