Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
> These TRANSLATORS comments weren't actually picked up by xgettext, the
> comment needs to be right before the Q_() function call, evidently it
> isn't picked up if that call is wrapped in another function call.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
The patch makes sense as an advice to people who update sources where to
place the "TRANSLATORS:" comment, but I am unsure about what this
particular one says. Are we assuming that translators do not know what the
sentence they are translating refers to?
> strbuf_addf(&sb,
> + /*
> + * TRANSLATORS: "+" in (+) is a line addition marker;
> + * do not translate it.
> + */
> Q_(", %d insertion(+)", ", %d insertions(+)",
> insertions),
What I am getting at is that this may be simply being unnecessarily noisy
by trying to be helpful, and I am not sure if you are drawing the line at
the right level. For example, "insertion" has many meanings and in the
context of this sentence it means lines added to the old material---should
we mention that here, and tell translators to use the word that conveys
that particular meaning?
For this particular one, I'd be happier if the TRANSLATORS comment told
them to check if "diffstat" (which we borrowed this from) has a l10n of
this message for the language they are translating to, and make sure they
use the same format here.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html