Re: [PATCH 2/2] git-svn: Configure a prompt callback for gnome_keyring.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eric,

> > This requires changes in the subversion perl bindings which have been
> > committed to trunk (1241554 and some followup commits) and should be
> > available with the (as of yet unreleased) 1.8.0 release.
> I'm a hesitant to use/depend on unreleased functionality in SVN.
> 
> Is there a chance the API could change before the release.  Also, what
> kind of tests do the SVN guys do on the Perl bindings + GNOME?  I'm
> especially concerned since we just worked around segfault bugs in the
> other patch.
There is a testcase for this particular function (though it only tests
calling the function, not the full workings because no gnome-keyring is
available in the testsuite).

As for the other segfault: the reason for that one was that apparently
swig autogenerates bindings even when some typemaps are missing and then
just puts an abort or failing assert or something like that in there.
Unlikely to happen here, but I understand your restraint.

> Can we put this on hold until somebody can test the 1.8.0 release?
Sure, the change won't be useful without svn 1.8.0 anyway (and since
it's not a critical feature, we can live without it in the window
between 1.8.0 and the next git release as well).

I'll try to keep any eye on the 1.8.0 release. According to the svn
roadmap [1] it is planned for july (1.7.0 + 9 months) but looking at the
list of features "not started", I'd say it might be later...

http://subversion.apache.org/roadmap.html

Gr.

Matthijs

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]