luke@xxxxxxxxxxx wrote on Tue, 24 Apr 2012 09:08 +0100: > This is a reworked version of my earlier patches for adding > improved label import/export support to "git p4", and > incorporates comments from Pete Wyckoff and Junio: > > Comments from Pete: > > * The verbose flag has been hoisted to the Command class. Thanks, this looks great. > * Uses the existing functions to fish out p4 changelist numbers. > * Config options renamed to be self-consistent, and regexp > now includes lower-case characters. > > I have left the tests in t9811 where they are, so that the t9804 > script can be used solely for "--detect-labels". Oh, okay. 9804 is about --detect-labels, which still has the two-labels-on-same-changelist problem. 9811 is the new stuff, and the similar test there works. Anyway, ack your v4 that is this plus your doc fix. Thanks, -- Pete > Comments from Junio: > > * P4EDITOR is set to the always-true value in the test harness > * Treat an empty P4EDITOR the same as an unset P4EDITOR. > > There was a discussion about having "git p4" fall back to a default in > the same way that "p4" does, but this would change the existing behavior > (use git var GIT_EDITOR) and confuse users. > > This patch series was reworked against ld/git-p4-tags-and-labels and > also has a very small documentation fix. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html