Shawn Pearce <spearce@xxxxxxxxxxx> writes:
> Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
>> Hi,
>>
>> On Thu, 14 Dec 2006, Shawn O. Pearce wrote:
>>
>> > +int is_bare_git_dir (const char *dir)
>> > +{
>> > + if (!strcmp(dir, DEFAULT_GIT_DIR_ENVIRONMENT))
>> > + return 0;
>> > + const char *s = strrchr(dir, '/');
>> > + return !s || strcmp(s + 1, DEFAULT_GIT_DIR_ENVIRONMENT);
>> > }
>>
>> This function does not really determine if the repo is bare. I have no
>> better name for it, though.
>
> guess_if_bare_git_dir ?
>
> I struggled to name that thing because it can't really tell, its just
> guessing... but it is going to be right most of the time. Of course
> I'm sure there's some Git user somewhere who will confuse it.
I think the name is fine, but probably a comment in front would
help unconfuse people.
/* Does it look like a repository without a working tree? */
Unfortunately there currently are public bare repositories that
have index under them because they were primed by rsync from
developers' working repositories. I do not think it is
unreasonable to persuade owners of them to drop index -- then we
could use absence of $GIT_DIR/index as a strong clue that the
repository is bare.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html