Nguyễn Thái Ngọc Duy wrote:
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -464,3 +464,36 @@ void strbuf_addstr_urlencode(struct strbuf *sb, const char *s,
[...]
> +int printf_ln(const char *fmt, ...)
> +{
> + int ret;
> + va_list ap;
> + va_start(ap, fmt);
> + ret = vprintf(fmt, ap);
> + va_end(ap);
> + if (ret >= 0)
> + ret += printf("\n");
Missed a spot. I'd do
if (ret < 0 || putchar('\n') == EOF)
return -1;
return ret + 1;
And likewise, for the fprintf version:
if (ret < 0 || putc('\n', fp) == EOF)
return -1;
return ret + 1;
Hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html