junio@xxxxxxxxx wrote on Sun, 22 Apr 2012 19:40 -0700:
> Pete Wyckoff <pw@xxxxxxxx> writes:
>
> > Clemens suggested disabling the test by default, as I've done
> > here. I think it would be okay to remove it entirely, too.
>
> Ok.
>
> > +# Generally, skip this test. It demonstrates a now-fixed
> > +# race in git-remote-testgit, but is too slow to leave in
> > +# for general use.
> > +test_expect_success DEBUG_TESTGIT_RACE 'racily pushing to local repo' '
> > + cp -a server server2 &&
> > + git clone "testgit::${PWD}/server2" localclone2 &&
> > + test_when_finished "rm -rf server2 localclone2" &&
>
> Shouldn't test_when_finished come before these two commands? Otherwise
> server2 or localclone2 directories will be left behind when they fail
> before control reaches it...
Yes, you're right.
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html