On Fri, Apr 20, 2012 at 02:51:58PM -0700, Junio C Hamano wrote: > > It looks like we will prefer sys/poll.h if it exists. The official XSI > > location is "poll.h", but I guess in practice they are equivalent on > > most systems if you have both (certainly on Linux, poll.h just includes > > sys/poll.h). > > There actually is no preference between the two from _our_ side. It is > up to the builder to know and define necessary make variables. I say "prefer" only because if you set nothing, you get "sys/poll.h". So it is up to the builder to say "no, I do not have that non-standard location. Use the standard one instead". Which seems a little backwards. Of course "standard" here is just what POSIX says; sys/poll.h may be much more standard in the real world (I don't know). > > Does your environments have a sys/poll.h that exists isn't sufficient to > > use poll? Maybe we need to tweak git-compat-util to include both if they > > both exist. > > Both? I guess, but I suspect that on most sane systems one would > include the other if there are both provided (iow, just so that you can > complile sources written both for XSI and for systems in the field). I would think one or the other would be fine. But the fact that Sven's patch works makes me think that he has sys/poll.h, but it is not sufficient. Hopefully including "poll.h" would be enough, but it's not clear to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html