On Wed, Apr 18, 2012 at 01:21:16PM -0700, Jeff King wrote: > > I am perfectly OK with even without initializers, like this: > > > > struct argv_array repack = ARGV_ARRAY_INIT; > > argv_array_push_strings(&repack, "repack", "-d", "-l", NULL); > > I think that is sane, and certainly the simplest. I'll send a patch in a > moment. Here it is. This goes directly on top of 7e52f56 (the tip of jk/repack-no-explode-objects-from-old-pack). The off-by-one fix I sent earlier can be dropped, as that code is removed by the final patch below. [1/3]: argv-array: refactor empty_argv initialization [2/3]: argv-array: add a new "pushl" method [3/3]: gc: use argv-array for sub-commands -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html