On Mon, Apr 16, 2012 at 11:48, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Lucian Poston <lucian.poston@xxxxxxxxx> writes: > >> Add output_prefix_length to diff_options. Initialize the value to 0 and only >> set it when graph.c:diff_output_prefix_callback() is called. >> >> Signed-off-by: Lucian Poston <lucian.poston@xxxxxxxxx> >> --- >> diff.h | 1 + >> graph.c | 3 +++ >> 2 files changed, 4 insertions(+), 0 deletions(-) > > This patch is a no-op, as nobody pays attention to the value this field > contains. I think it is better to squash this with 3/7 where you > introduce the only user of this field. > > Also when that happens, you would need to adjust the test vector, which > may mean that you need to squash the result with 4/7 as well. Squashed. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html