On Mon, Apr 16, 2012 at 11:48, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> @@ -117,7 +117,7 @@ cat >expect40 <<'EOF' >> abcd | 1000 ++++++++++++++++++++++++++ >> EOF >> cat >expect40-graph <<'EOF' >> -| abcd | 1000 ++++++++++++++++++++++++++ >> +| abcd | 1000 ++++++++++++++++++++++++ >> EOF >> while read verb expect cmd args >> do >> @@ -127,12 +127,6 @@ do >> test_cmp "$expect" actual >> ' >> >> - test_expect_success "$cmd $verb statGraphWidth config" ' >> - git -c diff.statGraphWidth=26 $cmd $args >output >> - grep " | " output >actual && >> - test_cmp "$expect" actual >> - ' >> - > > This is unclear. Why does this need to be removed? This test was actually only moved. There were 4 test_expect_success in a while loop -- 2 tested COLUMNS=40, and 2 tested diff.statGraphWidth=26. I moved the two tests for diff.statGraphWidth to a new while loop. expect40-graph varies between these two sets of tests, so I thought it cleaner to separate them so that the expectation could be defined separately. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html