On 12-04-17 11:26 AM, Junio C Hamano wrote: > marcnarc@xxxxxxxxxxx writes: > >> It turns out that ref->peer_ref is always NULL in update_local_ref(). So I >> made its caller pass in the full remote ref as a new parameter. I also added >> a unit test. >> >> This series is a complete resend of all the patches discussed in these >> threads, including Jens's submodule recursion fix. > > Thanks, but I'd prefer to keep unrelated things as separate unless there > is a compelling reason not to. > > Also I do not think renaming of the existing parameter in the first patch > is warranted, especially when the new parameter you are adding is more > descriptive (i.e. "remote_ref" in the context of that function makes it > clear enough that it is not just a string but is a pointer to a ref > structure). > > So let's do this. I'm good with both your patches. Thanks much for fixing my work! M. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html