Felipe Contreras wrote: > Perhaps it's time to avoid the __ prefix for public interfaces; > otherwise how would people know they are public? I'm happy as long as all the identifiers the script exports start with an underscore, as that is the usual convention for completion scripts. Within that namespace, if people want to use ___git or _git__ for private things or something, I don't mind. If __git_ps1 is moved to a separate script library, it seems fine for it to provide a git_ps1 identifier with no leading underscores when it is not being implicitly included by the completion script. Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html