Re: [PATCH v3 1/5] completion: simplify __gitcomp_1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 15, 2012 at 10:29:17AM +0200, Andreas Schwab wrote:
> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
> 
> > However, I would like to simplify it even more:
> >
> > __gitcomp_1 ()
> > {
> > 	local c w s IFS=' '$'\t'$'\n'
> > 	for c in $1; do
> > 		w="$c$2"
> > 		case "$w" in
> > 		--*=*|*.) s="" ;;
> > 		*)        s=" " ;;
> > 		esac
> > 		printf "%s$s\n" "$w"
> > 	done
> > }
> 
> Or even:
> 
> __gitcomp_1 ()
> {
> 	local c IFS=$' \t\n'
> 	for c in $1; do
> 		c=$c$2
> 		case $c in
> 		--*=*|*.) ;;
> 		*)        c="$c " ;;
> 		esac
> 		printf '%s\n' "$c"
> 	done
> }

We can even get rid of the %s with

  printf -- "$c\n"

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]