On Fri, Apr 13, 2012 at 06:49:49PM -0500, Jonathan Nieder wrote: > Jeff King wrote: > > > If anything, should this > > not be moving the cat inside the test_expect_success? > > That would be fine with me. It would involve changing the ' around > "master" to '\'' and would mean that if some later patch wants to use > the same message, the author will have to remember to factor it out. Ah, yeah, that is probably why I left it outside the test in the first place. > On the other hand, nothing about the message is specific to that test > assertion, so I am ok with the patch I sent, too. I don't care much either way. I just know that there are a million other places that set up "expect" right before the test, so it seems like a common exception to our rule. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html