On Fri, Apr 13, 2012 at 01:34:46PM +0300, Felipe Contreras wrote: > >> + run_completion "git f" && > >> + ! grep -q -v "^f" out > > > > grep is not a git command, so I'm not sure, but shouldn't these use > > 'test_must_fail grep' instead of '! grep'? > > I'm not sure. Junio has already queued this, maybe you should send a > patch on top of that. It seems that both are used in the test suite, but '! grep' is more common, so perhaps it's good as it is. $ git grep '! grep' -- t |wc -l 136 $ git grep 'test_must_fail grep' -- t |wc -l 17 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html