Re: [PATCH 1/5] t1507: add additional tests for @{upstream}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/11/2012 07:57 PM, Junio C Hamano wrote:
Junio C Hamano<gitster@xxxxxxxxx>  writes:

Zbigniew Jędrzejewski-Szmek<zbyszek@xxxxxxxxx>  writes:

+error_message () {
+	(cd clone&&
+	 test_must_fail git rev-parse --verify "$@")
+}
...
+test_expect_success 'branch@{u} error message when no upstream' '
+	cat>expect<<-EOF&&
+	error: No upstream branch found for ${sq}non-tracking${sq}
+	fatal: Needed a single revision
+	EOF
+	(cd clone&&
+	 test_must_fail git rev-parse --verify non-tracking@{u}) 2>actual&&

Why not use "error_message" as other new tests?
There _was_ some reason, in some earlier version of the patch, but now it
is gone. Will use error_message.

I think the remainder of the message should be ignored.  Will comment on
individual steps.

Thanks.
I'll try to improve the description in first patch to not confuse people :)

Thanks,
Zbyszek
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]